cleanup: use NewWithOptions replace the Deprecated one #21243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanup: use NewWithOptions replace the Deprecated one
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up client initialization by replacing the deprecated madmin.New call with the new madmin.NewWithOptions.
- Removes manual error checking and custom transport setup by moving these options into the NewWithOptions call.
- Simplifies the code by directly returning the result of the NewWithOptions constructor.
harshavardhana
approved these changes
Apr 28, 2025
klauspost
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup: use NewWithOptions replace the Deprecated one
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
cleanup: use NewWithOptions replace the Deprecated one
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)