Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@BasixKOR
Copy link
Contributor

@BasixKOR BasixKOR commented Jun 6, 2025

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Fixes #21364 by adding Region to the Minio client options.

Motivation and Context

The prior code did not set the region for the Minio client, which caused issues with S3-compatible storage providers that require a region to be set.

I'm not sure how to integrate the existing tests to properly test this; Minio would accept any requests with region not configured on client side, causing the effect to be invisible.

Also note that this may cause issues with existing Minio deployments as the connection detail would be changed.

How to test this PR?

You may run a two Minio servers:

  • One for ILM S3 backend, with region configured to non-default
  • One for using the ILM.

And add the first one to the second one as an ILM tier, as shown in the linked issue. I was able to test this PR locally and was able to successfully add a Ncloud Storage as a remote tier.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@BasixKOR BasixKOR changed the title fix: add region config to s3 client on ilm s3 backend [ILM] fix: add region config to s3 client on ilm s3 backend #21364 Jun 6, 2025
@BasixKOR BasixKOR force-pushed the fix/ilm-s3-region branch from 7f1a6c2 to f95d939 Compare June 6, 2025 13:13
@harshavardhana harshavardhana merged commit 417c864 into minio:master Jun 8, 2025
21 checks passed
@BasixKOR BasixKOR deleted the fix/ilm-s3-region branch June 9, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ILM S3 remote tier does not include region in the credentials

4 participants