[ILM] fix: add region config to s3 client on ilm s3 backend #21364 #21365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Fixes #21364 by adding
Regionto the Minio client options.Motivation and Context
The prior code did not set the region for the Minio client, which caused issues with S3-compatible storage providers that require a region to be set.
I'm not sure how to integrate the existing tests to properly test this; Minio would accept any requests with region not configured on client side, causing the effect to be invisible.
Also note that this may cause issues with existing Minio deployments as the connection detail would be changed.
How to test this PR?
You may run a two Minio servers:
And add the first one to the second one as an ILM tier, as shown in the linked issue. I was able to test this PR locally and was able to successfully add a Ncloud Storage as a remote tier.
Types of changes
Checklist:
commit-idorPR #here)