Update tls.md with correct keys in certConfig
#1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Mar 29, 2022
dvaldivia
requested changes
Mar 29, 2022
docs/tls.md
Outdated
| - commonName: By default this is set to a wild card domain name as per [Kubernetes StatefulSet Pod Identity](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#pod-identity). Set it any other value as per your requirements. | ||
|
|
||
| - organizationName: By default set to `system:node`. Change it to the name of your organization. | ||
| - organizationName: By default set to list `[system, node]`. Change it to the name of your organization. Any value added under this section will be appended to the list of existing organization names. |
There was a problem hiding this comment.
Suggested change
| - organizationName: By default set to list `[system, node]`. Change it to the name of your organization. Any value added under this section will be appended to the list of existing organization names. | |
| - organizationName: By default set to list `["system:node"]`. Change it to the name of your organization. Any value added under this section will be appended to the list of existing organization names. |
we do set the default to system:nodes
There was a problem hiding this comment.
Good catch; updated. I was wrong about the name being appended too.
ravindk89
reviewed
Mar 29, 2022
There was a problem hiding this comment.
@dvaldivia Looking at https://github.com/minio/operator/blob/master/docs/crd.adoc#k8s-api-github-com-minio-operator-pkg-apis-minio-min-io-v2-certificateconfig
What is the actual example here - e.g.
certConfig:
organizationName:
- "somestring"
- "another string"
- "<system>"
- "<node>"
?
ravindk89
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
I think this is fine, but @dvaldivia it might be good for us to have an actual example of organizationName at some point. But that doesn't have to be now.
Alevsk
approved these changes
Mar 30, 2022
dvaldivia
approved these changes
Mar 31, 2022
|
Thanks for your contribution @tobiasmcnulty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.