Fixing annotation issue on helm chart #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
approved these changes
Apr 5, 2022
adfost
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue on PR: #1071
I did not tested until now, and it is not working because of this issue:
The solution is simple, this is a string value by default, and it is not a function (Solution: "http"):
- prometheus.io/scheme: {{ dig "metrics" "protocol" http . | quote }} + prometheus.io/scheme: {{ dig "metrics" "protocol" "http" . | quote }}By doing so and if we enable the
Annotationsthen we will get proper value and not a crash when deploying: