fix: ParseRawConfiguration bug #1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Apr 7, 2022
harshavardhana
requested changes
Apr 7, 2022
252ad46 to
735698e
Compare
harshavardhana
previously approved these changes
Apr 7, 2022
- added unit tests - uses similar logic to the one used on MinIO Signed-off-by: Lenin Alevski <[email protected]>
735698e to
d372f56
Compare
dvaldivia
approved these changes
Apr 8, 2022
harshavardhana
approved these changes
Apr 8, 2022
bexsoft
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=Signed-off-by: Lenin Alevski [email protected]