Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding kind configuration for NodePort Testing #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Adding kind configuration for NodePort Testing #1434

merged 1 commit into from
Feb 6, 2023

Conversation

@cniackz
Copy link
Contributor

@cniackz cniackz commented Feb 3, 2023 •
edited
Loading

Objective:

To test NodePort in our Operator Service, added kind configuration for that.

Reason:

I have some functions I would like to use with different config:

     13 function createcluster() {
     14         kind delete cluster
     15         kind create cluster --config ~/operator/testing/kind-config.yaml
     16 }

@cniackz cniackz self-assigned this Feb 3, 2023
allanrogerr
allanrogerr approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful!

shtripat
shtripat approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjuarezd pjuarezd merged commit 7824287 into minio:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjuarezd pjuarezd pjuarezd approved these changes

@shtripat shtripat shtripat approved these changes

@allanrogerr allanrogerr allanrogerr approved these changes

@bexsoft bexsoft Awaiting requested review from bexsoft

@dilverse dilverse Awaiting requested review from dilverse

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@reivaj05 reivaj05 Awaiting requested review from reivaj05

Assignees

@cniackz cniackz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cniackz @pjuarezd @shtripat @allanrogerr