Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@feorlen
Copy link
Collaborator

@feorlen feorlen commented May 28, 2025

New SDK page for the Rust SDK, with a quickstart from minio/minio-rs/README.md

Going with an external link to a generated reference. Will deal with API.md as we can.
We may yet get an API.md, so this PR is a draft for now.

@feorlen feorlen marked this pull request as draft May 28, 2025 20:07
@HJLebbink HJLebbink requested a review from Copilot May 28, 2025 20:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the Rust SDK in our documentation and sync script.

  • Updates sync-docs.sh to include Rust in SDK sync, source directory mapping, and version replacement
  • Introduces a Quickstart guide and RST wrapper for the Rust SDK
  • Adds a placeholder API.md for Rust and updates the drivers overview to list Rust SDK

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sync-docs.sh Added “rs” to SDKS list, mapped source_dir to “rust”, and added RUSTVERSION replace call
source/developers/rust/quickstart.md Created Rust SDK quickstart guide
source/developers/rust/minio-rust.rst Added RST page including the quickstart and toctree entry
source/developers/rust/API.md Placeholder file returning “404: Not Found”
source/developers/minio-drivers.rst Added Rust SDK to the drivers list and toctree
Comments suppressed due to low confidence (2)

sync-docs.sh:44

  • The script attempts to fetch API.md for Rust even though it doesn't exist yet, resulting in a 404 placeholder. Consider conditionally skipping the API.md download for the rust SDK or handling missing API docs gracefully.
curl --retry 10 -Ls -o source/developers/${source_dir}/API.md https://raw.githubusercontent.com/minio/minio-${sdk}/${sdk_version}/${sdk_dir}/API.md

sync-docs.sh:41

  • [nitpick] Indentation for the Rust case branch is inconsistent with the other SDK cases. Align the tabs/spaces to match existing formatting for readability.
                source_dir="rust" # no API.md yet

@feorlen feorlen marked this pull request as ready for review June 4, 2025 14:42
@feorlen feorlen merged commit 6090d38 into main Jun 4, 2025
1 check passed
@feorlen feorlen deleted the add-rust-sdk branch June 4, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants