This repository was archived by the owner on Jun 19, 2025. It is now read-only.
kes: add support for API key authentication #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e9ab7a to
af404e0
Compare
| case config.APIKey != nil: | ||
| cert, err = kes.GenerateCertificate(config.APIKey) | ||
| if err != nil { | ||
| } |
shtripat
reviewed
Apr 19, 2023
Contributor
shtripat
left a comment
There was a problem hiding this comment.
Minor comment. Also how to verify the changes?
internal/keystore/kes/kes.go
Outdated
| if config.PrivateKey == "" { | ||
| return nil, errors.New("kes: no private key provided") | ||
| if config.APIKey != nil && (config.PrivateKey != "" || config.Certificate != "") { | ||
| return nil, errors.New("kes: ambiguous configuration: API key as well as mTLS private key and certificate provided") |
Contributor
There was a problem hiding this comment.
API key as well as mTLS private key and/or certificate provided ?
af404e0 to
effeabc
Compare
This commit adds support for KES<->KES authentication via API keys. Now, a KES edge server can authenticate to a KES server (stateful) via API keys - not just via TLS private key / certificate files. Signed-off-by: Andreas Auernhammer <[email protected]>
effeabc to
2170223
Compare
Contributor
|
Please resolve the conflict and add steps for verification. I feel we can add a wiki for the this mechanism of API keys authentication, right? |
|
@aead PTAL |
f832434 to
63649d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for KES<->KES authentication via API keys. Now, a KES edge server can authenticate to a KES server (stateful) via API keys - not just via TLS private key / certificate files.