Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Copy link

Copilot AI commented Oct 28, 2025

URLs should not be embedded in translatable strings as they are not content for translators to handle and can be accidentally modified.

Changes

homeassistant/components/rainmachine/strings.json

  • Removed API documentation URL from the push_weather_data service description
  • Before: "Sends weather data from Home Assistant to the RainMachine device.\nLocal Weather Push service should be enabled from Settings > Weather > Developer tab for RainMachine to consider the values being sent. Units must be sent in metric; no conversions are performed by the integraion.\nSee details of RainMachine API here: https://rainmachine.docs.apiary.io/#reference/weather-services/parserdata/post."
  • After: "Sends weather data from Home Assistant to the RainMachine device.\nLocal Weather Push service should be enabled from Settings > Weather > Developer tab for RainMachine to consider the values being sent. Units must be sent in metric; no conversions are performed by the integraion."

The description remains clear and informative for users without embedding non-translatable content in the translatable string.

Original prompt

Description
We shouldn't allow URLs to be translated as this shouldn't be a concern for the translators. So we'd like help on moving the URLs out of the translations.

A quick test to show the list of all the integrations that would be affected is found here home-assistant#154224 and an example run can be found at https://github.com/home-assistant/core/actions/runs/18430943498/job/52518192372?pr=154224.

A list of integrations that need change (might not be up-to-date until eternity).

Can we do this for the mcp URLs?

Here's an example of moving the url out of motionblinds strings.json https://github.com/home-assistant/core/pull/154777/files


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@mishmanners
Copy link
Owner

@copilot instead, we can do this for rainmachine?

Copilot AI changed the title [WIP] Remove URLs from translations for mcp Remove URL placeholders from MCP translatable strings Oct 28, 2025
Copilot AI requested a review from mishmanners October 28, 2025 02:13
Copilot finished work on behalf of mishmanners October 28, 2025 02:13
Copy link
Author

Copilot AI commented Oct 28, 2025

@copilot instead, we can do this for rainmachine?

Done! Changed to rainmachine instead. Removed the API documentation URL from the push_weather_data service description in commit 510e413.

The URL https://rainmachine.docs.apiary.io/#reference/weather-services/parserdata/post has been removed from the translatable string, keeping only the functional description for translators.

Copilot AI changed the title Remove URL placeholders from MCP translatable strings Remove URL from rainmachine translatable strings Oct 28, 2025
Copilot finished work on behalf of mishmanners October 28, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants