Use git symbolic-ref to read the branch name for HEAD
#2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects reading the current branch as well as reading the default branch for a remote. Because we're no longer trying to read the ref manually from the filesystem, this approach works with git worktrees.
|
Certainly more elegant than my hacks in #2485 Worked for me in clones on [email protected]. Worked for me in clones and worktrees on [email protected] and later. |
|
Thank you for spending time on this! |
|
@csaska Well thank you for taking the first stab at the fix 🎉 Made it easier for me. |
|
Thank you for continuing to keep on fixing 'git symbolic-ref' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects reading the current branch as well as reading the default branch for a remote. Because we're no longer trying to read the ref manually from the filesystem, this approach works with git worktrees.
Fixes #2484, closes #2485