client: support for password authentication fixes #31 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
approved these changes
Feb 21, 2023
This changes the API of Client.make (now receives a variant `Password of string | `Pubkey of key), and Awa_mirage.Make().client_of_flow as well. This does not support the keyboard-interactive authentication mechanism (RFC 4256) that is commonly used (with e.g. PAM), but only the password authentication. May be useful for feature parity between server and client, and for some network devices.
c7bb2d6 to
f148000
Compare
Member
Author
|
this has been revised and is ready for review. What it does:
|
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Mar 22, 2023
CHANGES: * server: be able to stop using a Lwt_switch.t (mirage/awa-ssh#52 @dinosaure) * server: add Pty/Set_env/Start_shell events (mirage/awa-ssh#53 @dinosaure) * client: support password authentication and keyboard-interactive (mirage/awa-ssh#51 @hannesm, reported by @dgjustice mirage/awa-ssh#31) * client: add NIST EC curves (mirage/awa-ssh#31 @hannesm) * client: try public key authenticaion only once (mirage/awa-ssh#50 @reynir @hannesm) * remove (partially implemented) hostbased authentication (mirage/awa-ssh#31 @hannesm) * replace deprecated Cstruct.copy by Cstruct.to_string (mirage/awa-ssh#53 @dinosaure) * remove ppx_cstruct and sexplib dependencies (mirage/awa-ssh#54 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the API of Client.make (now receives a variant
Password of string |Pubkey of key), and Awa_mirage.Make().client_of_flow as well.This does not support the keyboard-interactive authentication mechanism (RFC 4256) that is commonly used (with e.g. PAM), but only the password authentication. May be useful for feature parity between server and client, and for some network devices.