Add authentication information to auth Done state #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for keeping information such as what username was authenticated with.
Member
|
looks fine |
Member
Author
|
I am considering adding |
Member
Author
|
I merged it as it is. I can experiment with threading authentication information further at a later point and open another PR. |
reynir
added a commit
to reynir/opam-repository
that referenced
this pull request
May 28, 2025
CHANGES: * Add `Server.close`, fix close message semantics (mirage/awa-ssh#79 @reynir, review @hannesm) * Add authentication information in `Server.auth_state` `Done _` constructor (mirage/awa-ssh#80 @reynir, review @hannesm) * Make `Awa_mirage.Auth.lookup_user` public as it were before mirage/awa-ssh#74 (mirage/awa-ssh#81 @palainp, review @reynir)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for keeping information such as what username was authenticated with, or what public key was used.