Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@icyJoseph
Copy link
Contributor

Attempts to fix #109 by using column-reverse for the main container on narrow screens and flex:1 for the sliders.

It also keeps the top bar navigation across all screens (perhaps not wanted)

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   78.99%   78.99%           
=======================================
  Files          53       53           
  Lines        1219     1219           
  Branches      141      141           
=======================================
  Hits          963      963           
  Misses        223      223           
  Partials       33       33           
Impacted Files Coverage Δ
src/components/pages/LegPatternPage.js 57.89% <ø> (ø)
src/components/generic/Slider.js 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aba32e...5678635. Read the comment docs.

@mithi
Copy link
Owner

mithi commented Jul 7, 2020

@icyJoseph

Thanks for cleaning up my horrible css file. 😆 The inverse kinematics page looks fantastic..

But this happens in the leg patterns page...

Screen Shot 2020-07-07 at 9 29 45 PM

Screen Shot 2020-07-07 at 9 21 30 PM

@icyJoseph
Copy link
Contributor Author

Let's see if the latest changes finally settle down the sliders 😄

@mithi
Copy link
Owner

mithi commented Jul 7, 2020

Let's see if the latest changes finally settle down the sliders 😄

@icyJoseph perfect! Amazing! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Sliders on leg patterns / ik page changes size when the user is sliding it at certain screens

2 participants