Training repository to try review process
- clone this repository
- create a new branch with name suggesting the feature/bug you plan to commit. I this case "review-traning-"
- Make changes and commits for the feature/bug. For out traning we can create "first name-last name.md"
- push the branch
- create pull request from git project page. Once the pull request has be created it will be avaiable for all to review
- You can assign reviewers.
- Anybody can comment on pull requets. There can be conversations in the pull request.
- A pull request can be explicitly approved or rejected
- You can address issues raised part of the review but pushing newer commits to the
- Once there is consensus and we can move forward
- from the github web GUI you can merge into master
- check the option to delete branch after merge
- There are options to squash commits/retain commits, you would have to choose along with your reviewers what makes most sense in the context.
- view past "closed" pull requests.
- all comments and conversations part of the pull request will be visible.
- it is possible to comment on closed pull request.