Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automatically convert underscores to hyphens in attrs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 10, 2022
Merged

Automatically convert underscores to hyphens in attrs #17

merged 4 commits into from
Aug 10, 2022

Conversation

mixxorz
Copy link
Owner

@mixxorz mixxorz commented Aug 7, 2022 •
edited
Loading

This PR adds the ability to use data-, aria-, or other HTML attributes that have hyphens on the {% attrs %} tag.

For example:

{# logo component #}
<a {% attrs href aria_label %}><img src="logo.png" /></a>

{# Usage #}
{% logo href="/" aria_label="Slipper's logo" %}

{# Output #}
<a href="/" aria-label="Slipper's logo"><img src="logo.png" /></a>

This fixes #16 .

@mixxorz mixxorz mentioned this pull request Aug 7, 2022
Closed
lolrenx
lolrenx previously approved these changes Aug 8, 2022
View reviewed changes
@mixxorz mixxorz merged commit da760a8 into main Aug 10, 2022
@mixxorz mixxorz deleted the feature/handle-hyphens branch August 10, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lolrenx lolrenx lolrenx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow {% attrs %} to render hyphenated attributes ( aria-label, data-script etc)

2 participants

@mixxorz @lolrenx