Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@arjunsuresh
Copy link
Contributor

No description provided.

@arjunsuresh arjunsuresh requested a review from a team as a code owner September 17, 2024 10:43
@github-actions
Copy link

github-actions bot commented Sep 17, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@gfursin gfursin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good! Thanks!

@gfursin
Copy link
Contributor

gfursin commented Sep 17, 2024

Actually, didn't look at the right tests - they seem to be failing ...

@gfursin
Copy link
Contributor

gfursin commented Sep 17, 2024

I think we should use "tmp_cm_repo" instead of "." (not sure if GitHub changes directory via "cd tmp_cm_repo") ...

@gfursin gfursin merged commit b3651d0 into mlcommons:dev Sep 17, 2024
2 of 14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
@gfursin
Copy link
Contributor

gfursin commented Sep 17, 2024

Oh, no, it works fine. It's just that it seems that it's not picking the right branch of cm4mlops repo. My changes are in dev: mlcommons/cm4mlops@14972b4

@gfursin
Copy link
Contributor

gfursin commented Sep 17, 2024

I will merge it with main ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants