Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@BenWilson2
Copy link
Member

@BenWilson2 BenWilson2 commented Oct 21, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18431/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18431/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18431/merge

…ions

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Add support for setting the databricks-sdk ENV VAR for profile usage based on the MLflow tracking URI used during dataset operations. Since the databricks-agents package does not support creating WorkspaceClient instances that utilize a profile, locally setting this variable is a viable approach to have consistent resolution in a natively supported Client manner.

Tested fully e2e with profiles to use all CRUD APIs (create, merge_records, to_df, and delete) on a non-default workspace to ensure that this works as expected.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions github-actions bot added area/evaluation MLflow Evaluation rn/feature Mention under Features in Changelogs. labels Oct 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Documentation preview for 2625c9b is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@harupy
Copy link
Member

harupy commented Oct 22, 2025

/review


🚀 Review workflow started


✅ Review completed

Perfect! I've completed the PR review for PR #18431. I found and commented on 4 style guide violations:

Review Summary

Issues Found:

  1. mlflow/genai/datasets/__init__.py:32 - Missing return type hint on the _databricks_profile_env() context manager function. Should use Generator[None, None, None] type hint.

  2. tests/genai/datasets/test_fluent.py:420 - Missing type hint on monkeypatch parameter in test_databricks_profile_env_var_set_from_uri()

  3. tests/genai/datasets/test_fluent.py:463 - Missing type hint on monkeypatch parameter in test_databricks_profile_env_var_overridden_and_restored()

  4. tests/genai/datasets/test_fluent.py:485 - Missing type hint on monkeypatch parameter in test_databricks_dataset_merge_records_uses_profile()

All comments have been added to the PR with suggestions that can be applied with one click. The issues relate to the Python style guide requirement that all functions (including test functions) must have type hints on their parameters.


dataset = get_dataset(name="catalog.schema.table")

assert os.environ.get("DATABRICKS_CONFIG_PROFILE") is None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we apply #18431 (comment) to other assert statemenst?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry - forgot to get back to manually updating after I had accepted the suggestion... got side tracked!

Signed-off-by: Ben Wilson <[email protected]>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenWilson2 BenWilson2 enabled auto-merge October 23, 2025 02:29
@BenWilson2 BenWilson2 added this pull request to the merge queue Oct 23, 2025
Merged via the queue into mlflow:master with commit 5516c5d Oct 23, 2025
45 checks passed
@BenWilson2 BenWilson2 deleted the databricks-datasets-profile branch October 23, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/evaluation MLflow Evaluation rn/feature Mention under Features in Changelogs. team-review Trigger a team review request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants