-
Notifications
You must be signed in to change notification settings - Fork 5k
Add support for profile usage in Databricks Agents dataset API operat… #18431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for profile usage in Databricks Agents dataset API operat… #18431
Conversation
…ions Signed-off-by: Ben Wilson <[email protected]>
|
Documentation preview for 2625c9b is available at: More info
|
|
/review ✅ Review completedPerfect! I've completed the PR review for PR #18431. I found and commented on 4 style guide violations: Review SummaryIssues Found:
All comments have been added to the PR with suggestions that can be applied with one click. The issues relate to the Python style guide requirement that all functions (including test functions) must have type hints on their parameters. |
Co-authored-by: Harutaka Kawamura <[email protected]> Signed-off-by: Ben Wilson <[email protected]>
tests/genai/datasets/test_fluent.py
Outdated
|
|
||
| dataset = get_dataset(name="catalog.schema.table") | ||
|
|
||
| assert os.environ.get("DATABRICKS_CONFIG_PROFILE") is None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we apply #18431 (comment) to other assert statemenst?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry - forgot to get back to manually updating after I had accepted the suggestion... got side tracked!
Signed-off-by: Ben Wilson <[email protected]>
harupy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🛠DevTools ðŸ›
Install mlflow from this PR
For Databricks, use the following command:
…ions
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Add support for setting the databricks-sdk ENV VAR for profile usage based on the MLflow tracking URI used during dataset operations. Since the databricks-agents package does not support creating WorkspaceClient instances that utilize a profile, locally setting this variable is a viable approach to have consistent resolution in a natively supported Client manner.
Tested fully e2e with profiles to use all CRUD APIs (create, merge_records, to_df, and delete) on a non-default workspace to ensure that this works as expected.
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.