Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Prasiddhi
Copy link
Contributor

Added MiniBatchKmeans from ClusterR package.

Prediction is via predict_MBatchKMeans of ClusterR package.

We are always happy to receive pull requests.

Please make sure you have read our coding guidelines:
https://github.com/mlr-org/mlr/wiki/mlr-Coding-Guidelines

This especially means that you have understood:

  • The style guide - our lintr will provide you feedback on this
  • How to run tests locally. Yes, travis will also run them for you, bad it is annoying to wait for this.
  • How to run R CMD CHECK locally. See point before.

Also it's helpful to get into direct contact with the suggested reviewers to get help, getting your PR merged.
You might want to join our slack at:
https://mlr-org.slack.com

@pat-s
Copy link
Member

pat-s commented May 14, 2019

@Prasiddhi
Thanks for contributing. Could you please add the package to DESCRIPTION and an entry to NEWS.md, following the structure you find in there?

@pat-s
Copy link
Member

pat-s commented May 19, 2019

@larskotthoff If you approve, please merge.

@larskotthoff
Copy link
Member

Thanks, merging.

@larskotthoff larskotthoff merged commit 9763ad1 into mlr-org:master May 20, 2019
vrodriguezf pushed a commit to vrodriguezf/mlr that referenced this pull request Jan 16, 2021
* Added MiniBatchKmeans of ClusterR package

* Added another parameter setting to test

* Update NEWS.md

* Update DESCRIPTION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants