Conversation
pat-s
reviewed
May 14, 2019
Member
pat-s
left a comment
There was a problem hiding this comment.
Could you also add an entry to NEWS.md?
DESCRIPTION
Outdated
| VignetteBuilder: | ||
| knitr | ||
| Remotes: | ||
| berndbischl/BBmisc, |
Member
There was a problem hiding this comment.
Was this change on purpose or bc the Travis build failed back then?
Member
Author
There was a problem hiding this comment.
Is there a reason why why install the devel version? If yes, we need to upload BBmisc before the next CRAN release. Otherwise it would be best to use the exact same version CRAN uses.
Member
There was a problem hiding this comment.
AFAIK there was but probably all problems have been fixed? I released v2.14.0 ofc without the Remotes Field and everything seems to be fine. So yes, I guess we can drop these requirements.
pat-s
approved these changes
May 19, 2019
Member
|
@mllg I added NEWS, please merge if you approve. |
Member
Author
|
Perfect, thanks! |
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st attempt to fix #2578