Update gbm learners #2651
Merged
Update gbm learners #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskotthoff
requested changes
Oct 8, 2019
R/RLearner_classif_gbm.R
Outdated
| note = "`keep.data` is set to FALSE to reduce memory requirements. Note on param 'distribution': gbm will select 'bernoulli' by default for 2 classes, and 'multinomial' for multiclass problems. The latter is the only setting that works for > 2 classes. It is recommended to NOT use the 'multinomial' setting, see https://github.com/mlr-org/mlr/issues/2612", | ||
| note = paste0(collapse = "", c("`keep.data` is set to FALSE to reduce memory requirements.\n", | ||
| "Note on param 'distribution': gbm will select 'bernoulli' by default for 2 classes, and 'multinomial' for multiclass problems.\n", | ||
| "The latter is the only setting that works for > 2 classes. It is recommended to NOT use the 'multinomial' setting, see https://github.com/mlr-org/mlr/issues/2612.", |
Member
There was a problem hiding this comment.
This is confusing. There's no "multinomial" value anymore, and the default doesn't depend on the task here.
Member
Author
There was a problem hiding this comment.
Yes, good catch. Removed the note about "multinomial" entirely as it does not apply anymore.
R/RLearner_regr_gbm.R
Outdated
| name = "Gradient Boosting Machine", | ||
| short.name = "gbm", | ||
| note = '`keep.data` is set to FALSE to reduce memory requirements, `distribution` has been set to `"gaussian"` by default.', | ||
| note = poaste0(collapse = "", c('`keep.data` is set to FALSE to reduce memory requirements, `distribution` has been set to `"gaussian"` by default.', |
Member
There was a problem hiding this comment.
Mentioned default value for distribution is incorrect. Same note on distribution as for classification learner here?
Member
Author
There was a problem hiding this comment.
Ah I was lazy here. Sorry. Default now "gaussian" and the classif learner was changed as well.
larskotthoff
approved these changes
Oct 8, 2019
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
* upd gbm distribution argument * upd shrinkage and distribtion argument * update learner note * document n.cores change * add NEWS * correct regr.gbm distribution param * clear note about 'multinomial' param for classif.gbm * fix classif_gbm test * add multionomial option for distribution param again * Deploy from Travis build 14223 [ci skip] Build URL: https://travis-ci.org/mlr-org/mlr/builds/597271702 Commit: 2e4bceb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2642
shrinkagefrom 0.001 to 0.1n.coresand suppress parallelization by defaultdistributionwith the actual package defaultsdistribution