Fix ranking of ensemble filters #2698
Merged
+4,356
−2,999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2019
use select.method instead of additonal ensemble if-clause
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
* ensure that ensemble filters rank correctly * rename * fix filterFeatures() behavior and add test * style * method -> filter for internal robustness; use select.method instead of additonal ensemble if-clause * fix test * upd precommit yml * fix tests and upd roxygen * add NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2685
rename
calcBaseFilters()torankBaseFilters()add tests checking for correct order of filter values and their corresponding rank
filterfeatures(): add test checking for correct subsetting of the task