- Fix order of learners in generateLearningCurveData()#2768
Merged
Conversation
pat-s
approved these changes
Jun 15, 2020
Member
pat-s
left a comment
There was a problem hiding this comment.
Thanks! I assume you checked against R 3.6 and R 4.0? Good to go from my side. A NEWS entry would be great.
Member
Author
|
I added a NEWS entry. However, I did not check against R 3.6. The new solution does not use anything that is critical in this regard. |
Member
|
Ok, fair enough. Let's assume its fixed for now if there are no new reports incoming. No time to write a test for this now. |
generateLearningCurveData()
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #2767 and generally cleans up the code a bit to avoid wrong orderings of each column.