Account for {checkmate} v2.0.0 update #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
* Account for {checkmate} v2.0.0 (mlr-org#2734)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2733
Actually fixed the test to check for two measures in
tuneParamsMultiCrit()and fail if only one is provided.Beforehand the error was triggered to due a class check (the supplied
Measureobject is a list and passing it without being wrapped in alistcauses the issue thattuneParamsMultiCrit()tries to use all elements ofMeasureas a measure instead of treating the passed object as a single measure) and not the fact that only one measure was supplied.