fix(lr-scheduler): add argument to plateau, infer steps for 1cycle, add more tests #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebffischer
requested changes
Jun 17, 2025
…es == 0 for plateau
cxzhang4
commented
Jun 20, 2025
tests/testthat/helper_autotest.R
Outdated
|
|
||
| super_cbgen_public_methods = cbgen$get_inherit()$public_methods | ||
| superclass_implemented_stages = names(super_cbgen_public_methods)[grepl("^on_", names(super_cbgen_public_methods))] | ||
| implemented_stages = union(superclass_implemented_stages, names(cbgen$public_methods)[grepl("^on_", names(cbgen$public_methods))]) |
Collaborator
Author
There was a problem hiding this comment.
I think it makes sense to check the superclass for implemented stages, since a subclass would inherit any stages that it doesn't override.
Collaborator
Author
There was a problem hiding this comment.
And without this change, the autotest does not detect a stage as implemented when it is only implemented in the superclass
cxzhang4
commented
Jun 20, 2025
cxzhang4
commented
Jun 20, 2025
sebffischer
requested changes
Jun 24, 2025
R/CallbackSetLRScheduler.R
Outdated
| scheduler = NULL, | ||
| #' @description | ||
| #' Creates a new instance of this [R6][R6::R6Class] class. | ||
| #' @param .scheduler (`LRScheduler`)\cr |
tests/testthat/helper_autotest.R
Outdated
|
|
||
| super_cbgen_public_methods = cbgen$get_inherit()$public_methods | ||
| superclass_implemented_stages = names(super_cbgen_public_methods)[grepl("^on_", names(super_cbgen_public_methods))] | ||
| implemented_stages = union(superclass_implemented_stages, names(cbgen$public_methods)[grepl("^on_", names(cbgen$public_methods))]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.