Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@RaphaelS1
Copy link
Contributor

No description provided.

@RaphaelS1 RaphaelS1 marked this pull request as draft October 30, 2020 11:06
@RaphaelS1 RaphaelS1 marked this pull request as ready for review October 30, 2020 11:11
@RaphaelS1
Copy link
Contributor Author

This isn't essential until proba 0.2.3 on CRAN but is required to stop the book breaking when using GH versions (https://github.com/mlr-org/mlr3book/runs/1329451322)

@mllg
Copy link
Member

mllg commented Oct 30, 2020

Does this PR need the dev version of proba or not? I'm confused.

@RaphaelS1
Copy link
Contributor Author

Yes but I'm doing a CRAN release now anyway (which will break viz) so you can merge this tomorrow if that's fine for you

@mllg
Copy link
Member

mllg commented Oct 30, 2020

Alright, will merge tomorrow and update mlr3viz.

@RaphaelS1
Copy link
Contributor Author

The autoplot uses target_names not feature_names which is why it breaks

@RaphaelS1 RaphaelS1 changed the title Fix density plots for dev proba Fix density plots, add PredictionSurv Oct 30, 2020
@RaphaelS1 RaphaelS1 marked this pull request as draft October 30, 2020 12:45
@mllg mllg marked this pull request as ready for review November 1, 2020 19:55
@mllg mllg merged commit 2a4e22e into master Nov 1, 2020
@mllg mllg deleted the fix_density_plots branch November 1, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants