drop row id from [stats::prcomp()] data #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
giuseppec
added a commit
that referenced
this pull request
Mar 14, 2021
mllg
added a commit
that referenced
this pull request
Mar 15, 2021
drop rowid before pca, fix PR #67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task_datacontain arow_idcolumn that is then passed tostats::prcomp()to perform pca.mlr3viz/R/PredictionClust.R
Lines 77 to 88 in 993bc44
This inhibits pathologic principal components, especially for scaled data as row_id might scale to large numbers for increasing data sets...