Fix Windows compilation and debug assertion failure#110
Merged
danielzgtg merged 3 commits intomainfrom Aug 15, 2025
Merged
Conversation
Closed
LostRuins
approved these changes
Aug 14, 2025
Contributor
|
Can confirm this is necessary and fixes native compile on windows for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #109
Also gets this to build in VS Code on Windows with https://gist.github.com/robotdad/83041ccfe1bea895ffa0739192771732 by fixing the array initialization. I've also tested
winget install --interactive MSYS2.MSYS2and https://code.visualstudio.com/docs/cpp/config-mingw , whose Debug button is too slow, but the Launch is fine.The phonemizer change fixed undefined behavior, but I'm not sure that bug had caused the crash in #104.
settings.jsonI used for testing:{ "files.associations": { "array": "cpp" }, "cmake.debugConfig": { "args": [ "-nt", "4", "-p", "Hello", "-mp", "C:\\Users\\Home\\Downloads\\Kokoro_no_espeak.gguf" ] } }