Match inputs containing hyphens against parameter names#26
Merged
mnapoli merged 3 commits intomnapoli:masterfrom Aug 31, 2016
Merged
Match inputs containing hyphens against parameter names#26mnapoli merged 3 commits intomnapoli:masterfrom
mnapoli merged 3 commits intomnapoli:masterfrom
Conversation
src/Application.php
Outdated
| $this->expressionParser = new ExpressionParser(); | ||
| $this->invoker = new Invoker(); | ||
|
|
||
| if ($this->invoker->getParameterResolver() instanceof ResolverChain) { |
Contributor
Author
There was a problem hiding this comment.
I wasn't sure how to go about this. Would you prefer to be more explicit and specify all the resolvers instead of relying on the default?
Owner
There was a problem hiding this comment.
Yes I think it would be better to pass all the resolvers explicitly, that would be clearer.
Contributor
Author
|
An aside to think about: Something else I've come across (though, quite rarely) are options that begin with a number. I don't know if those are common enough to want to support (esp. since you can't start a variable w/ a number in PHP — or most languages for that matter). |
Owner
|
Awesome! Regarding options that start with a number I think it's enough of a edge case to not support it at the moment. |
Owner
|
Thanks! |
|
This is awesome, thanks for the effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible specify a argument or option name with a hyphen in it (e.g.
--dry-run) and have that match a parameter name in the callable like$dryRun.This is unfortunate because multi-word options are a quite common occurrence in tools.
e.x. the version of rsync I have installed has 57 (!) multi-word options and 39 of those are not aliased.
Also, in some cases (like
--dry-run) the wording used is quite common so that's what would be reached for first.I took some time to create a resolver that will un-hyphenate and lowercase the names before matching against closure parameters to solve this issue.