feat: bump yargs to 17 #5165
Merged
feat: bump yargs to 17 #5165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Oct 30, 2024
JoshuaKGoldberg
commented
Oct 30, 2024
| .wrap(process.stdout.columns ? Math.min(process.stdout.columns, 80) : 80) | ||
| .epilog( | ||
| `Mocha Resources | ||
| `${ansi.reset("Mocha Resources")} |
There was a problem hiding this comment.
This epilog(ue) wasn't being printed before. Now it is. On error, everything is red, so this ansi.reset is needed to make the colors actually show through.
JoshuaKGoldberg
commented
Oct 30, 2024
| }, | ||
| 'list-reporters': { | ||
| conflicts: Array.from(ONE_AND_DONE_ARGS), | ||
| conflicts: Array.from(ONE_AND_DONE_ARGS).filter(arg => arg !== "list-reporters"), |
There was a problem hiding this comment.
Without these:
2 failing
1) --list-interfaces
should dump a list of all interfaces with descriptions:
Uncaught UnexpectedError:
expected 1 to be 0
at /home/runner/work/mocha/mocha/test/integration/options/listInterfaces.spec.js:26:7
at ChildProcess.<anonymous> (test/integration/helpers.js:352:5)
at ChildProcess.emit (node:events:519:28)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5)
set UNEXPECTED_FULL_TRACE=true to see the full stack trace
2) --list-reporters
should dump a list of all reporters with descriptions:
Uncaught UnexpectedError:
expected 1 to be 0
at /home/runner/work/mocha/mocha/test/integration/options/listReporters.spec.js:29:7
at ChildProcess.<anonymous> (test/integration/helpers.js:352:5)
at ChildProcess.emit (node:events:519:28)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5)
set UNEXPECTED_FULL_TRACE=true to see the full stack trace
Changed since review; re-requested
|
v11.1.0 is marked as "next" in npm, v11.0.1 is still "latest". Is that on purpose? |
|
Ah, it's not - thanks @gausie! I just updated the tag on npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Bumps
yargsand related packages to their latest versions:yargs: from16.2.0to17.7.2yargs-parser: from20.2.9to21.1.1Both still support Node >= 12.