feat: add mocha.mjs export #5527
Conversation
|
For now let's exclude the private keys, they shouldn't be necessary for this export. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5527 +/- ##
==========================================
- Coverage 93.69% 93.57% -0.12%
==========================================
Files 57 57
Lines 4391 4465 +74
Branches 850 918 +68
==========================================
+ Hits 4114 4178 +64
- Misses 277 287 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for the review! I saw the linting failed after the merge, so I added my addition of |
|
Fixed the build error, but not sure how to manually test this one. Going to unassign myself as this isn't a focus area for me compared to bugfixes and the v12 release, but hopefully after v12 we can come back to this. Thanks for getting this started and continuing to follow up! |
|
@JoshuaKGoldberg if you want to help me clean up PRs you can help review this one ;) |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
This looks good but I can't get it to work - is something missing?
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Confirmed this actually does work now. Great! ✨
Requesting changes to make it a little more informative if users mess this up. IME forgetting to run mocha.setup("bdd") (or running it out of order) is pretty easy to do.
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looks great to me, thanks! Bouncing back to @mark-wiemer for re-review as it's changed since Mark's last review.
At some point I think we'll want to revamp the browser-testing docs. But they're already pretty out of date separately from this, and will be captured by general docs cleanups.
…-mod-not-found * 'ts-mod-not-found' of github.com:sam-super/mocha: feat: add mocha.mjs export (mochajs#5527) docs: bumped docs-next Astro to ^5.16.6 (mochajs#5574) build(dev-deps): upgrade `markdownlint-cli` to latest v0.46.0 (mochajs#5560)
PR Checklist
status: accepting prsOverview
Adds an ESM export file for use in the browser.
The other non-underscored (private) keys I saw on the global
mochaobject which I wasn't sure which I might include were the following:files,options,suite,isWorker,throwError,ui