build(dev-deps): upgrade eslint from v8 to v9
#5559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
mark-wiemer
requested changes
Dec 3, 2025
Member
mark-wiemer
left a comment
There was a problem hiding this comment.
This looks pretty good, just a couple suggestions :)
Signed-off-by: hainenber <[email protected]>
cb853ec to
baf9cdf
Compare
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5559 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 57 57
Lines 4465 4465
Branches 918 918
=======================================
Hits 4176 4176
Misses 289 289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mark-wiemer
approved these changes
Dec 6, 2025
JoshuaKGoldberg
approved these changes
Dec 10, 2025
Member
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM, thanks! 🚀
I was tripped up a bit by the removals of the inline disables. Most of the rules are actually ones I was expecting to be enabled. But they're not, and enabling them separately would be a followup issue (#5281 & friends).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This PR upgrades
eslintfrom major version 8.x to 9.x. I'm very thankful for insights given by @Lightning00Blade in the original issue ontry-catchissue with currently used Rollup bundler.Contrary to other dev deps upgrade,
eslintv9 is bit bloat-y but it helps out with tons of outdated transitive deps instead so it's a net positive IMO.