-
Notifications
You must be signed in to change notification settings - Fork 466
Add recbuf config option. #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are several moments, you need to address. Second. I add ability not to configure And third, I did not wrote any tests for changing |
src/mochiweb_socket_server.erl
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use case for comparing with undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that understood correctly: do you want me to change RecBufOpt = if RecBuf == undefined ... to same thing but with case RecBufOpt = case RecBuf of undefined -> ... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
|
I did force push with backward compatibility functions added, also I returned usage of |
|
Rebased to current master and removed ability to set |
|
Looks great, thank you! |
resolve #133