c8d/pull: Emit Aux messages containing raw OCI registry errors #51726
+296
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecd3a02 to
e233983
Compare
e233983 to
6a202a3
Compare
It does two things, so split it to two functions. Signed-off-by: Paweł Gronowski <[email protected]>
Previously, registry errors were only handled through generic error translation. Enhance the image pull operation to extract and emit OCI registry errors as auxiliary progress messages when pull operations fail. This allows clients to receive the original, unprocessed registry error enabling better error reporting and handling in the Docker CLI and other API consumers. Signed-off-by: Paweł Gronowski <[email protected]>
Invert the branch which allows us to return early Signed-off-by: Paweł Gronowski <[email protected]>
6a202a3 to
0e9b3a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, registry errors were only handled through generic error translation.
Enhance the image pull operation to extract and emit OCI registry errors as auxiliary progress messages when pull operations fail.
This allows clients to receive the original, unprocessed registry error enabling better error reporting and handling in the Docker CLI and other API consumers.
- A picture of a cute animal (not mandatory but encouraged)