feat: migrate modelpack and support build the model as reasoning model #237
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @chlins, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on a significant refactoring effort to migrate the project's namespace from CloudNativeAI to modelpack across the entire codebase, ensuring a consistent and updated identity. Concurrently, it introduces a new feature that enables users to designate models as 'reasoning models' during the build process, enhancing the categorization and metadata of built models.
Highlights
- Project Namespace Migration: The project's namespace has been comprehensively migrated from
CloudNativeAItomodelpack. This change impacts Go import paths, configuration files (.golangci.yml,.mockery.yaml), documentation (README.md,docs/getting-started.md,build/package/docs/modctl.1*), and Go module definitions (go.mod,go.sum), ensuring consistency and reflecting the new branding. - Reasoning Model Support: A new
--reasoningflag has been introduced to themodctl buildcommand. This flag allows users to explicitly mark a model as a 'reasoning model' during the build process, which is then recorded in the model's configuration (ModelConfigandModelCapabilitieswithin themodel-spec).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly renames the project namespace from CloudNativeAI to modelpack and updates all relevant files, including configurations, source code, and documentation. The introduction of the --reasoning flag for the build command is a good addition for model categorization.
My review has identified one critical issue where the new Reasoning capability is not preserved when using the attach command, which could lead to silent data loss in the model's metadata. Please see the detailed comment for the fix.
Otherwise, the changes look good and the namespace migration appears complete and correct.
Signed-off-by: chlins <[email protected]>
This pull request focuses on renaming the project namespace from
CloudNativeAItomodelpackacross various files and configurations. Additionally, it introduces a new flag for marking models as reasoning models in the build configuration. Below are the most important changes grouped by theme:Namespace Update:
.github/workflows/release.yaml: Updated namespace in build flags fromgithub.com/CloudNativeAI/modctltogithub.com/modelpack/modctl. [1] [2].golangci.yml: Changed the formatter prefix to reflect the new namespace..mockery.yaml: Updated package paths for backend, storage, modelfile, and build interfaces.README.md: Updated badges and links to use the newmodelpacknamespace.cmd/*.gofiles: Updated import paths to usemodelpacknamespace across multiple commands such asattach,build,extract,fetch,inspect,list,login,logout,modelfile/generate,prune,pull,push,rm, androot. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Documentation Updates:
build/package/docs/modctl.1andmodctl.1.md: Updated GitHub Issues link to use the new namespace. [1] [2]Feature Addition:
cmd/build.go: Added a new--reasoningflag to mark models as reasoning models in the configuration.These changes ensure consistency across the codebase and introduce a new feature for enhanced model categorization.