Coping with non-unique dependency jar names #261
+175
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no guarantee that the
artifactId+versionof a dependency is unique, soCreateRuntimeImage's dependency inclusion behaviour of copying jars into a single directory is failure-prone: projects with dependencies that differ only by theirgroupIdwill provoke ajava.nio.file.FileAlreadyExistsException.This change will detect such cases and prepend the
groupIdto the destination jar name.A related problem also exists in
AddModuleInfo- ideally it'd have an option akin todependency:copy'sprependGroupId