-
-
Couldn't load subscription status.
- Fork 532
Onbeforepluginformdelete #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opengeek
added a commit
that referenced
this pull request
Apr 6, 2013
Merge remote-tracking branch 'rtripault/fix-1' into refactor-1 * rtripault/fix-1: [1] - See http://tracker.modx.com/issues/1 Allow duplication of elements when editing
This was referenced May 6, 2011
This was referenced Aug 18, 2011
theboxer
pushed a commit
that referenced
this pull request
Jun 23, 2015
Mark-H
pushed a commit
that referenced
this pull request
Aug 9, 2015
Update create.class.php - pre-complete fieldsin resource
Mark-H
pushed a commit
that referenced
this pull request
Aug 10, 2015
[^p^] tag output fix on locales with comma as decimal point
pixelchutes
pushed a commit
that referenced
this pull request
Dec 8, 2015
bugfix #131 in modmore/Gitify
Jako
pushed a commit
that referenced
this pull request
May 9, 2016
Update modinstallrunner.class.php
theboxer
pushed a commit
that referenced
this pull request
Jan 27, 2017
JoshuaLuckers
pushed a commit
that referenced
this pull request
Mar 6, 2019
Add message about updating settings
JoshuaLuckers
pushed a commit
that referenced
this pull request
Mar 6, 2019
gpsietzema
added a commit
to sdrenth/revolution
that referenced
this pull request
Apr 25, 2019
Media browser reload
Mark-H
pushed a commit
that referenced
this pull request
Sep 9, 2019
Applying profile edit changes from PR 14578
Merged
opengeek
pushed a commit
that referenced
this pull request
May 6, 2025
### What does it do? Better error handling in the `Workspace/Packages/Rest/GetList` processor. ### Why is it needed? While searching for extras in the "Package Browser", the code throws a fatal error when there is a problem with the connection. ``` Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given ``` --- The `find()` function of the class `modTransportProvider` returns a string if there is a error: https://github.com/modxcms/revolution/blob/11d96669133bab7f1095c96be63368f841d8dbd7/core/src/Revolution/Transport/modTransportProvider.php#L333
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnBeforePluginFormDelete exists but is never invoked. I added back the invocation to match the other OnBeforeObjectFormDelete events.