Fix Media Browser Sorting by Modification Date (Follow-up) #16772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures system settings' default sort is applied when 'lastmod' is chosen.
|
@jenswittmann - Hey, since you pointed out the issue fixed here, can you pull down this PR to test it sometime soon? Thx! |
|
Hej @smg6511, |
|
@jenswittmann - You're most welcome! If you would, give the PR an official review approval so this can get merged in sooner than later. |
jenswittmann
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures system settings'
modx_browser_default_sortis properly applied when 'lastmod' is chosen.What does it do?
Accounts for recently-implemented
lastmod_rawkey in the browser logic; allows users who have their default sort set tolastmodto not have to make any changes for that setting to work.Why is it needed?
When system setting is set to
lastmod, browser views were still being sorted by name on initial load.How to test
Change your
modx_browser_default_sortto each of the three variations allowed and ensure sorting appears as expected in each of the browser contexts:Related issue(s)/PR(s)
In response to request in Issue #16731