Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@OptimusCrime
Copy link
Contributor

@OptimusCrime OptimusCrime commented Sep 5, 2017

What does it do?

If you are moving textfields and textareas to modx-resource-main-left or modx-resource-main-right, they are slightly too wide on the right side, breaking the bounderies of their surrounding columns.

Please note that this is untested! I copied the code from @pepebe 's original PR.

Test case

Please see original issue #13323

Why is it needed?

Fixes issue with styling.

Related issue(s)/PR(s)

Issue ##13323
PR #13344
Local PR pepebe/revolution/#2

@rthrash rthrash added this to the v2.6.1 milestone Dec 11, 2017
@Jako
Copy link
Contributor

Jako commented Dec 14, 2017

This PR should be enhanced, since the width and the box-sizing rule is applied only to textarea template variables. Other rules seems to be missing (input etc.).

@Jako Jako added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. bug The issue in the code or project, which should be addressed. priority-3-low labels Dec 14, 2017
@Jako Jako removed this from the v2.6.1 milestone Dec 14, 2017
@OptimusCrime
Copy link
Contributor Author

@Jako Care to elaborate how you tested this? I can take it for a spin and check if some of the other classes needs to be adjusted too.

@Jako
Copy link
Contributor

Jako commented Dec 14, 2017

I just have read the scss code. There is no width adjustment for a text TV. Only a textarea TV has a width: 100%!important;, which should do the job.

@OptimusCrime
Copy link
Contributor Author

I'll try to test this properly. I am still a bit unsure how this works.

@Mark-H
Copy link
Collaborator

Mark-H commented Jan 29, 2018

This habit of yours to submit PRs that other people made, without knowing how to test it, is interesting @OptimusCrime ;)

@Mark-H
Copy link
Collaborator

Mark-H commented Jan 29, 2018

This does not fix the problem reported in #13323. The built CSS resolves to this:

  .x-form-item #modx-resource-main-columns .modx-tv textarea {
    box-sizing: border-box;
    width: 100% !important;
    min-width: 200px; }
  .x-form-item #modx-resource-main-columns .modx-tv input[type="text"] {
    line-height: 20px;
    height: auto; }
  .x-form-item #modx-resource-main-columns .modx-tv .x-superboxselect-input-field {
    min-width: 200px; }

while the #modx-resource-main-columns should be at the front of the definition.

Would you like to correct this @OptimusCrime or should the PR be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants