Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(stage-ui-three): lipsync update() #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lilia-Chen merged 2 commits into from
Jan 18, 2026
Merged

fix(stage-ui-three): lipsync update() #971

Lilia-Chen merged 2 commits into from
Jan 18, 2026

Conversation

@Lilia-Chen
Copy link
Contributor

@Lilia-Chen Lilia-Chen commented Jan 18, 2026

Description

The lipsync was not updated in every frame after the value was set

simple fix. 1 line of code added.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 18, 2026

Summary of Changes

Hello @Lilia-Chen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the stage-ui-three component where VRM model lipsync animations were not updating dynamically. The change ensures that the model's expression manager is explicitly updated in each frame, which is crucial for maintaining fluid and accurate facial movements based on real-time lipsync data. This enhancement improves the visual fidelity and responsiveness of character animations.

Highlights

  • Lipsync Update Fix: Addressed a bug where lipsync expressions were not continuously updating after their values were set, leading to static or incorrect facial animations.
  • Continuous Expression Management: Introduced a call to activeVrm?.expressionManager?.update() within the animation loop to ensure that the VRM model's expressions, including lipsync, are processed and rendered every frame.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026 •
edited
Loading

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 18, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies and fixes a bug where VRM expressions, including lip-sync, blinking, and emotes, were not being updated in each frame. The addition of activeVrm?.expressionManager?.update() in the onBeforeRender loop is the correct solution, as it ensures that any changes made to expression values within the same frame are applied to the model. The placement of this call after all expression-modifying functions (vrmEmote.update, vrmLipSync.update, etc.) is also correct. The change is simple, effective, and necessary for the intended functionality.

@Lilia-Chen Lilia-Chen merged commit 372f356 into main Jan 18, 2026
9 checks passed
@Lilia-Chen Lilia-Chen deleted the lilia/fix branch January 18, 2026 12:55
@Lilia-Chen Lilia-Chen self-assigned this Jan 18, 2026
Joker-of-Gotham pushed a commit to Joker-of-Gotham/airi that referenced this pull request Jan 29, 2026
@Lilia-Chen @autofix-ci @Joker-of-Gotham
fix(stage-ui-three): lipsync update() (moeru-ai#971)
f5b5cc6 
* bug-fix: lipsync update

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Lilia-Chen Lilia-Chen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Lilia-Chen