Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@babu-ch
Copy link

@babu-ch babu-ch commented Oct 10, 2025

resolves #279

I also created a PR for mojs-player
mojs/mojs-player#23

@Sandstedt
Copy link
Member

LGTM. I let @xavierfoucrier take a look too.

@xavierfoucrier
Copy link
Member

Hello @babu-ch 👋

Thanks for opening a PR for that, I will need to check before merging of course.
Can give a look when I will be in vacation mode, soon.

Thanks for tagging me @Sandstedt 😎 😽

@nikolay-yankov
Copy link

Hello 👋 shall we upgrade directly to v24 (it's in active LTS now)?
My animation works fine with v24.11.1

Cheers 🍻

@xavierfoucrier
Copy link
Member

Trying to do my best this year, since I am father again.. it's a bit complicated at some point.
Anyway, yes, I will dive into this, 22/24, I will need to see but I guess no problem in both cases 😉

@babu-ch
Copy link
Author

babu-ch commented Dec 1, 2025

If v24 works fine, I can update this PR to bump the version to v24 as well.
Just let me know if you'd prefer that 👍

@xavierfoucrier
Copy link
Member

I prefer checking and doing it myself, because the mojs/core library is used in many other repos that I will need to update and check too, not only public repos.

Thanks for the PR 😉
Will try to move forward before end of year, sorry for the delay

@nikolay-yankov
Copy link

Trying to do my best this year, since I am father again.. it's a bit complicated at some point. Anyway, yes, I will dive into this, 22/24, I will need to see but I guess no problem in both cases 😉

Quelle belle nouvelle! Félicitations Xavier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPM Install Unsupported Engine

4 participants