Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ingest: speed up merging and dedup #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamdecaf merged 2 commits into from
Dec 11, 2025
Merged

ingest: speed up merging and dedup #677

adamdecaf merged 2 commits into from
Dec 11, 2025
+226 −72

Conversation

@adamdecaf
Copy link
Member

@adamdecaf adamdecaf commented Dec 11, 2025 

goos: darwin
goarch: arm64
pkg: github.com/moov-io/watchman/internal/ingest
cpu: Apple M4 Max

                     │   before.txt   │            after.txt            │
                     │     sec/op     │    sec/op     vs base           │
_Person12_09_2025-16   22736.5m ± ∞ ¹   411.6m ± ∞ ¹  ~ (p=1.000 n=1) ²

                     │   before.txt   │            after.txt             │
                     │      B/op      │     B/op       vs base           │
_Person12_09_2025-16   2903.0Mi ± ∞ ¹   123.9Mi ± ∞ ¹  ~ (p=1.000 n=1) ²

                     │  before.txt   │            after.txt            │
                     │   allocs/op   │  allocs/op    vs base           │
_Person12_09_2025-16   22.480M ± ∞ ¹   2.073M ± ∞ ¹  ~ (p=1.000 n=1) ²

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 11, 2025

Summary of Changes

Hello @adamdecaf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the performance of the entity ingestion pipeline by optimizing the merging and deduplication of entities. The primary change involves a complete overhaul of the merging algorithm, which now employs a custom, more efficient approach for grouping and combining entities. This refactoring has led to substantial improvements in processing speed and reduced memory footprint. Additionally, the PR includes updates to Go module dependencies and the introduction of a new testing utility to ensure the accuracy and maintainability of the revised merging logic.

Highlights

  • Performance Improvement: The pull request significantly speeds up the entity merging and deduplication process, as demonstrated by benchmarks showing drastic reductions in execution time, memory usage, and allocations.
  • Refactored Merge Logic: The core entity merging functionality in pkg/search/merge.go has been rewritten to use a custom, optimized grouping and iterative merging strategy, moving away from a generic merge library.
  • New Testing Utility: A new entitytest.Equal helper function has been introduced to provide robust, deep equality comparisons for search.Entity types, improving the reliability of merge tests.
  • Dependency Updates: Key Go module dependencies, including github.com/adamdecaf/merge and golang.org/x/exp, have been updated to their latest versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 11, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the performance of entity merging and deduplication by replacing a generic library with a specialized implementation. The benchmarks show impressive gains in speed and reductions in memory usage. The changes also include better error wrapping and more robust tests. I've identified an issue where several fields (Affiliations, HistoricalInfo, SanctionsInfo) are not being merged correctly, which could lead to data loss. I've provided a detailed comment with a suggested fix for this. Overall, this is a very positive change.

@adamdecaf adamdecaf merged commit aa6c493 into master Dec 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@ahrtmn ahrtmn ahrtmn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamdecaf @ahrtmn