download: remove default included lists, read INCLUDED_LISTS #682
Conversation
Summary of ChangesHello @adamdecaf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how Watchman determines which lists to download, moving away from hardcoded defaults in the configuration file. It introduces support for specifying included lists via an Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the default included lists, requiring users to explicitly configure them either in the config file or via a new INCLUDED_LISTS environment variable. The implementation looks good, and the new getIncludedLists function correctly merges lists from both sources. I've made a few suggestions to fix a typo in comments, improve the documentation to reflect this breaking change, and slightly refactor the new function for better readability.
0fabed6 to
c615843
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request modifies the download behavior to no longer include default lists, instead requiring users to specify them in the configuration file or via the INCLUDED_LISTS environment variable. The changes are well-implemented, updating the default configuration, documentation, and the core download logic. My feedback focuses on ensuring the documentation is consistent with the new default behavior and removing some now-unreachable code from the download process.
No description provided.