fix: isRequired field filledin check for boolean type column #5634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chinook25
approved these changes
Dec 9, 2025
| const formValues = ref<Record<string, columnValue>>({}); | ||
| const formValues = ref<Record<string, columnValue>>({ | ||
| // non empty required bool field | ||
| col6: false, |
Contributor
There was a problem hiding this comment.
could have used a meaningful id instead of repeating this comments
Contributor
Author
There was a problem hiding this comment.
yea this reuses the setup for all the tests , maybe we should organize using describe or multiple test. not sure it's a bit of a trade off between reuses and specific test setup. might also be a bit of a code smell that we are doing to much in a single module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where required boolean field with a value of false were counted as not being filled in
What are the main changes you did
How to test
Checklist