forked from dotnet/docs
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from dotnet:master #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
123
commits into
moljac:master
Choose a base branch
from
dotnet:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two definitions were transposed. Fixes #22690
* Quick review of the last copy * Readd full url to the example * Fix casing
* Document removed and obsoleted APIs in ASP.NET Core * Fix build warnings * React to build suggestion * Add clarifications
* Add upgrade assistant docs * Updates to arch guide for upgrade tool * Update toc.yml
I had added the wrong ms.custom value
* update links to ECMA standards ECMA launched an updated website early this year. This PR updates links to ECMA 334 (C#), ECMA 335 (CLI), and TR-84 (XML data formats) * fix build error. Missing opening parenthesis in link.
Fixes #16187 The usage of synchronous Task-returning methods is not generally recommended. See https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task The examples were valid, but can cause hard-to-diagnose issues. As we add more advanced async scenarios, this scenario belongs there, with more details about when it is and isn't appropriate. (`using` in the non-async method is the primary mistake to run into).
`GenEnvVariable` didn't appear in csharp/tutorials/AsyncStreams/start/IssuePRreport/IssuePRreport/Program.cs . so I think it's typo, I'm just getting start in c# and not sure this should be `GetEnvVariable`. Some of issue mention GetEnvVariable and didn't say it's typo , so sorry if it's already correct. Also sorry for my suck English.
* Discards article: Fix the section about the discard pattern * Update docs/csharp/discards.md Co-authored-by: Bill Wagner <[email protected]> Co-authored-by: Bill Wagner <[email protected]>
[C# Reference] URL is wrong. It's same with [C# Programming Guide] URL as above.
Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.CodeAnalysis](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix non compliable code The sample code doesn't compile. * Update docs/core/diagnostics/distributed-tracing.md Co-authored-by: Youssef Victor <[email protected]> * Apply suggestions from code review Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Bill Wagner <[email protected]>
Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Regex lookaround information updated Information in the regular expression grouping table added as discussed in #22282 (comment) * Update docs/standard/base-types/regular-expression-language-quick-reference.md Co-authored-by: Andy De George <[email protected]>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/coverlet-coverage/coverlet/releases) - [Commits](https://github.com/coverlet-coverage/coverlet/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/coverlet-coverage/coverlet/releases) - [Commits](https://github.com/coverlet-coverage/coverlet/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Remove leading space.
fix typo: "communicates over name*d* pipes" not name*s* pipes
The project's name is error
Noticed an extra ) when reading the doc.
* Update Fedora docs for .NET 5.0 .NET 5.0 is now available in the default Fedora repositories. Update docs to make that clearer. * Update docs/core/install/linux-fedora.md These links are wrong since they were taken from ./includes/ folder Co-authored-by: Andy De George <[email protected]> * Update docs/core/install/linux-fedora.md These links are wrong since they were taken from ./includes/ folder Co-authored-by: Andy De George <[email protected]> * Add zlib as a Linux/RPM dependency Co-authored-by: Andy De George <[email protected]>
* Remove unclear hosting model language Fixes #20073 * Update docs/architecture/blazor-for-web-forms-developers/hosting-models.md
* Update deploy-with-cli.md The "--self-contained false" switch is actually added to prevent creation of self contained deployment ( which, in addition to the application and its dependencies, also includes the dotnet runtime and libraries ). Self contained deployment is the default when -r switch is used with dotnet publish command. * Update docs/core/deploying/deploy-with-cli.md Co-authored-by: Andy De George <[email protected]> Co-authored-by: Andy De George <[email protected]>
* Add missing semi colon * Add using * Fix * Fix VB sample
* correction to exposing data with cachemetadata doc * update Additional resources request per 22585 Co-authored-by: Ryan Hutton <[email protected]>
* Update remove-runtime-sdk-versions.md * Update remove-runtime-sdk-versions.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )