ExpandToFullscreen option in PluginConfig #1666
Merged
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dsehnal
approved these changes
Oct 25, 2025
Comment on lines
+225
to
+226
| document.addEventListener('fullscreenchange', fullscreenChangeHandler); | ||
| document.addEventListener('webkitfullscreenchange', fullscreenChangeHandler); |
There was a problem hiding this comment.
This could cause a memory leak, so will need to add a dispose method too which unregisters the listeners during plugin.dispose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #1663, I have implemented the
PluginConfig.General.ExpandToFullscreenoption to enable fullscreen mode (but I don't have push rights for David's repository).A new
fullscreenchangehandler was added as well - the user might want to get out of the fullscreen mode using Escape and not by using the expand button.I have tried changing the configuration for the
docking-viewerapp which is working, referencing the value in theViewerclass works as well. Not sure about the URL params, though.Actions
[Unreleased]section ofCHANGELOG.mdpackage.json'scontributorsdocs