Added tagalog support #1197
Added tagalog support #1197
Conversation
|
The addition of Tagalog is great, but why did so many other languages change? |
|
Un-intentionally committed a few other changes ahead of time - let me roll back to that commit. As a sneak peek, the other language changes were to make the moment.js language libraries comply more with CLDR (http://cldr.unicode.org/)... |
|
The commit has been rolled back and should include just Tagalog language support. |
test/lang/tl-ph.js
Outdated
There was a problem hiding this comment.
We recently added tests in this form, but then quickly realized they don't work in the browser and modified them. Looks like you made this test between, though. Not your fault at all, obviously, but can you update this to match https://github.com/moment/moment/blob/develop/test/lang/en-gb.js#L354 ?
|
Looks good, other than that one test. Once you fix that, I'll merge this in. |
|
test file has been updated! everything should be all set! let me know if there's anything else I can work on for this. As a separate question, what is your take on CLDR standardization with formatting/naming conventions? |
|
Looks good. Thanks! On the CLDR thing, I haven't had a chance to look at it. Can you post what you have in a separate pull request and we can kick off the discussion? |
Added tagalog support