This repository was archived by the owner on Aug 8, 2024. It is now read-only.
[Reflection] Fix test dependencies #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Oct 23, 2018
Part of #9660 Instead of #11025 mono/corefx#152 needs to be merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including TypeInfoTests.netcoreapp.cs to mono corelib leads to compilation error
external/corefx/src/System.Runtime/tests/System/Reflection/TypeInfoTests.netcoreapp.cs(35,48): error CS0246: The type or namespace name 'Outside<>' could not be found (are you missing a using directive or an assembly reference?)It's due to dummy class dependencies that are placed in
external/corefx/src/System.Runtime/tests/System/TypeTests.cs(which is not included on mono corelib.)