This repository was archived by the owner on Aug 8, 2024. It is now read-only.
Build pkg-config as 64bit only, libtiff as universal and remove gtk-quartz-engine.py #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
approved these changes
Aug 29, 2019
…uartz-engine.py We hit troubles (mono/mono#13804) which are apparently related to lipo'ing so move the three packages that use it away from it. - pkg-config doesn't build as universal since the internal glib doesn't build because of 32/64bit configure mismatches (we'd need to do similar patches to what we do in glib.py) so just make it 64bit only. - libtiff also runs into the 32/64bit configure mismatch but we can fix it with a simple patch. I tested it works by running the repro from https://xamarin.github.io/bugzilla-archives/39/39865/bug.html . - gtk-quartz-engine.py is no longer used by MD/VSMac according to the team so remove it completely.
3043aa8 to
b88b9c7
Compare
akoeplinger
added a commit
to akoeplinger/mono
that referenced
this pull request
Aug 29, 2019
alexischr
approved these changes
Aug 29, 2019
Member
Author
|
@monojenkins backport 2019-08 |
akoeplinger
added a commit
to mono/mono
that referenced
this pull request
Aug 29, 2019
…uartz-engine.py (#16548) See mono/bockbuild#116
This was referenced Aug 29, 2019
Merged
Merged
akoeplinger
added a commit
to mono/mono
that referenced
this pull request
Aug 29, 2019
…uartz-engine.py (#16548) See mono/bockbuild#116 (cherry picked from commit 309cf1b) # Conflicts: # external/bockbuild
akoeplinger
added a commit
to mono/mono
that referenced
this pull request
Aug 29, 2019
…uartz-engine.py (#16548) See mono/bockbuild#116 (cherry picked from commit 309cf1b) # Conflicts: # external/bockbuild
akoeplinger
added a commit
to mono/mono
that referenced
this pull request
Aug 30, 2019
…uartz-engine.py (#16548) See mono/bockbuild#116 (cherry picked from commit 309cf1b) # Conflicts: # external/bockbuild
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit troubles (mono/mono#13804) which are apparently related to lipo'ing so move the three packages that use it away from it.
pkg-config doesn't build as universal since the internal glib doesn't build because of 32/64bit configure mismatches (we'd need to do similar patches to what we do in glib.py) so just make it 64bit only.
libtiff also runs into the 32/64bit configure mismatch but we can fix it with a simple patch.
I tested it works by running the repro from https://xamarin.github.io/bugzilla-archives/39/39865/bug.html .
gtk-quartz-engine.py is no longer used by MD/VSMac according to the team so remove it completely.