[aot] partial revert of #14043 #14135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to emit a real call here. On arm/android we would emit this now: ```asm ldr pc, =label .ltorg # place address of `label` here. ``` which is a jump to `label`, not a call. We need a different solution to make larger assemblies work, but for now I revert it so the `2019-02` intergration is unblocked. Partial revert of mono#14043
Contributor
Author
|
@monojenkins backport 2019-02 |
This was referenced Apr 19, 2019
alexischr
approved these changes
Apr 23, 2019
monojenkins
added a commit
that referenced
this pull request
Apr 23, 2019
[2019-04] [aot] partial revert of #14043 We need to emit a real call here. On arm/android we would emit this now: ```asm ldr pc, =label .ltorg # place address of `label` here. ``` which is a jump to `label`, not a call. We need a different solution to make larger assemblies work, but for now I revert it so the `2019-02` intergration is unblocked. Partial revert of #14043 Backport of #14135. /cc @lewurm
lewurm
added a commit
to lewurm/mono
that referenced
this pull request
Aug 23, 2019
This reverts commit 223e0bd.
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Aug 26, 2019
This reverts commit 223e0bd.
akoeplinger
pushed a commit
that referenced
this pull request
Aug 26, 2019
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Sep 4, 2019
This reverts commit 223e0bd.
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Sep 4, 2019
This reverts commit 223e0bd.
lewing
pushed a commit
that referenced
this pull request
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to emit a real call here. On arm/android we would emit this now:
which is a jump to
label, not a call.We need a different solution to make larger assemblies work, but for now
I revert it so the
2019-02intergration is unblocked.Partial revert of #14043