Fixed RuntimeType.GetConstructorCandidates("") to return 0 elements. #16054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mono#16010 The current behavior for GetConstructorCandidates when the name is null, "", or "*" is to return the set of constructors for the type. For "", .NET Core and .NET Framework return 0 elements. This PR adds a check for "" to match that behavior.
added 2 commits
August 6, 2019 09:34
marek-safar
reviewed
Aug 6, 2019
marek-safar
approved these changes
Aug 6, 2019
Contributor
Author
|
@monojenkins build Linux ARMv5 |
Contributor
Author
|
@monojenkins build failed |
Member
|
@monojenkins backport 2019-08 |
Member
|
@monojenkins backport 2019-06 |
This was referenced Aug 8, 2019
akoeplinger
pushed a commit
that referenced
this pull request
Aug 8, 2019
…elements. (#16109) * Fixed RuntimeType.GetConstructorCandidates("") to return 0 elements. #16010 The current behavior for GetConstructorCandidates when the name is null, "", or "*" is to return the set of constructors for the type. For "", .NET Core and .NET Framework return 0 elements. This PR adds a check for "" to match that behavior. * Removed unncessary changes * Unnecessary spaces * Made the if check a bit more readable Backport of #16054.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16010
The current behavior for GetConstructorCandidates when the name is null, "",
or "*" is to return the set of constructors for the type. For "", .NET Core and
.NET Framework return 0 elements. This PR adds a check for "" to match that
behavior.